add more vendors support. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlmontanari
requested changes
Oct 10, 2024
There was a problem hiding this comment.
hey @wangxin688 thanks for this! I dropped a few comments in there. mostly just trying to keep things consistent with other platforms and scrapli community. if we can get those sorted we can get this merged. thanks a bunch!
|
@carlmontanari thanks for your comments, I have update the codebase base on your advices |
|
👋 @wangxin688 thanks for the updates! I just pushed a small commit with some cosmetic changes. I also deleted the fortinet platform for now since you mentioned you were going to revisit that later. if you're happy w/ this let me know and well get this merged! thanks a ton for all the work on this! |
|
everything looks good. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.